Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a check to prevent attempting to load a directory within patterns #3326

Merged

Conversation

LaurenceJJones
Copy link
Contributor

Fix: #3325

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind fix
/area agent

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.52%. Comparing base (fd314a3) to head (28db47d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/parser/unix_parser.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3326       +/-   ##
===========================================
+ Coverage   34.71%   58.52%   +23.81%     
===========================================
  Files         349      351        +2     
  Lines       37672    37676        +4     
===========================================
+ Hits        13076    22051     +8975     
+ Misses      23235    13730     -9505     
- Partials     1361     1895      +534     
Flag Coverage Δ
bats 41.30% <0.00%> (?)
unit-linux 34.45% <0.00%> (-0.01%) ⬇️
unit-windows 29.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit dd52e13 into crowdsecurity:master Nov 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crowdsec] Fatal at startup if patterns has a directory
2 participants