lint

coalesce/coalesce_test.go

@@ -60,6 +60,7 @@ func TestNotNil(t *testing.T) {
 				require.Nil(t, got)
 				return
 			}
+
 			require.NotNil(t, got)
 			assert.Equal(t, *tc.want, *got)
 		})

csdaemon/systemd.go

@@ -13,10 +13,10 @@ func NotifySystemd(log logrus.FieldLogger) error {
 }
 
 const (
-	Ready = daemon.SdNotifyReady
+	Ready     = daemon.SdNotifyReady
 	Reloading = daemon.SdNotifyReloading
-	Stopping = daemon.SdNotifyStopping
-	Watchdog = daemon.SdNotifyWatchdog
+	Stopping  = daemon.SdNotifyStopping
+	Watchdog  = daemon.SdNotifyWatchdog
 )
 
 // Notify systemd that the service is ready.

csstring/interpolate_test.go

@@ -2,6 +2,7 @@ package csstring_test
 
 import (
 	"testing"
+
 	"github.com/stretchr/testify/assert"
 
 	"github.com/crowdsecurity/go-cs-lib/csstring"

ptr/pointer.go

@@ -29,7 +29,9 @@ func OrEmpty[T any](t *T) T {
 	if t != nil {
 		return *t
 	}
+
 	var empty T
+
 	return empty
 }
 
@@ -38,6 +40,7 @@ func OrDefault[T any](t *T, def T) T {
 	if t != nil {
 		return *t
 	}
+
 	return def
 }
 

slicetools/chunk_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+
 	"github.com/crowdsecurity/go-cs-lib/slicetools"
 )
 
@@ -14,7 +15,7 @@ func TestChunks(t *testing.T) {
 		chunkSize int
 		expected  [][]int
 	}{
-		{ "empty slice, chunk size 2", []int{}, 2, [][]int{}},
+		{"empty slice, chunk size 2",  []int{}, 2, [][]int{}},
 		{"1 element, chunk size 2",    []int{1}, 2, [][]int{{1}}},
 		{"empty slice, chunk size 0",  []int{}, 0, [][]int{}},
 		{"5 elements, chunk size 2",   []int{1, 2, 3, 4, 5}, 2, [][]int{{1, 2}, {3, 4}, {5}}},

slicetools/deduplicate.go

@@ -6,14 +6,18 @@ func UniqueCopy[T comparable](slice []T) []T {
 	if slice == nil {
 		return nil
 	}
+
 	seen := make(map[T]struct{})
 	ret := make([]T, 0, len(slice))
+
 	for _, value := range slice {
 		if _, ok := seen[value]; !ok {
 			seen[value] = struct{}{}
+
 			ret = append(ret, value)
 		}
 	}
+
 	return ret
 }
 
@@ -24,8 +28,10 @@ func Deduplicate[T comparable](slice []T) []T {
 	if slice == nil {
 		return nil
 	}
+
 	seen := make(map[T]struct{})
 	j := 0
+
 	for _, value := range slice {
 		if _, ok := seen[value]; !ok {
 			seen[value] = struct{}{}

slicetools/deduplicate_test.go

@@ -2,6 +2,7 @@ package slicetools
 
 import (
 	"testing"
+
 	"github.com/stretchr/testify/assert"
 )
 
@@ -24,15 +25,18 @@ func TestUniqueIntegers(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			got := UniqueCopy(tc.slice)
 			assert.Equal(t, tc.want, got)
+
 			if len(got) > 0 {
 				assert.NotEqual(t, got, tc.slice[:len(got)], "UniqueCopy should not modify the original slice!")
 			}
 
 			got = Deduplicate(tc.slice)
 			assert.Equal(t, tc.want, got)
+
 			if len(got) > 0 {
 				assert.Equal(t, got, tc.slice[:len(got)], "Deduplicate should modify the original slice!")
 			}
+
 			for i := len(got); i < len(tc.slice); i++ {
 				assert.Equal(t, 0, tc.slice[i], "Deduplicate should zero out the remaining elements!")
 			}

trace/trace.go

@@ -22,10 +22,11 @@ import (
 // (i.e. config_paths.data_dir should be persistent even within containers)
 // If not called, the default is /tmp or equivalent
 func Init(dir string) error {
-	err := os.MkdirAll(dir, 0700)
+	err := os.MkdirAll(dir, 0o700)
 	if err != nil {
 		return err
 	}
+
 	keeper.dir = dir
 
 	return nil

yamlpatch/patcher.go

@@ -14,24 +14,22 @@ import (
 type Patcher struct {
 	BaseFilePath  string
 	PatchFilePath string
-	quiet bool
+	quiet         bool
 }
 
 func NewPatcher(filePath string, suffix string) *Patcher {
 	return &Patcher{
 		BaseFilePath:  filePath,
 		PatchFilePath: filePath + suffix,
-		quiet: false,
+		quiet:         false,
 	}
 }
 
-
 // SetQuiet sets the quiet flag, which will log as DEBUG_LEVEL instead of INFO
 func (p *Patcher) SetQuiet(quiet bool) {
 	p.quiet = quiet
 }
 
-
 // read a single YAML file, check for errors (the merge package doesn't) then return the content as bytes.
 func readYAML(filePath string) ([]byte, error) {
 	content, err := os.ReadFile(filePath)

yamlpatch/patcher_test.go

@@ -186,6 +186,7 @@ func TestMergedPatchContent(t *testing.T) {
 		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			dirPath, err := os.MkdirTemp("", "yamlpatch")
 			require.NoError(t, err)
 
@@ -289,6 +290,7 @@ func TestPrependedPatchContent(t *testing.T) {
 		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			dirPath, err := os.MkdirTemp("", "yamlpatch")
 			require.NoError(t, err)