This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
[LLVM Integrate] Bump llvm, torch-mlir #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zezhang
force-pushed
the
zezhang/upgrade
branch
from
c844b26 to
4237f03
Compare
tools/aot/execute_test.template.cpp
Outdated
Comment on lines
103
to
107
| // ##READ_REFERENCE_TENSORS_INTO_NPY_ARRAY##// | ||
| // cnpy::NpyArray refInput0 = reference_tensors["Input0"]; | ||
| // cnpy::NpyArray refInput1 = reference_tensors["Input1"]; | ||
| // cnpy::NpyArray refInput2 = reference_tensors["Input2"]; | ||
| // cnpy::NpyArray refOutput0 = reference_tensors["Output0"]; |
There was a problem hiding this comment.
(pre-emptive, I know this is very much WIP but wanted to throw it out there)
I'd avoid clang-format changes on this file, since it might break some of the match-replace patterns when we instantiate this template in aot_compile. You might want to ignore this file from clang-format, or make sure the patterns are correctly updated.
Comment on lines
56
to
58
| find . -type f -name "*.cpp" -a ! -name "*execute_test.template.cpp" -o -name "*.h" | xargs clang-format -i | ||
| if [ -n "$(git status --porcelain)" ]; then | ||
| echo "Please run 'find . -type f -name "*.cpp" -o -name "*.h" | xargs clang-format -i' and commit changes." | ||
| echo "Please run 'find . -type f -name "*.cpp" -a ! -name "*execute_test.template.cpp" -o -name "*.h" | xargs clang-format -i' and commit changes." |
There was a problem hiding this comment.
Prefer using a .clang-format-ignore file at the project root to track ignored files, to avoid this command from blowing up.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
sjain-stanford
approved these changes
Jan 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM (Nov 13)
Torch-MLIR (Jan 21)
StableHlo (Oct 25 - No Change)
Also fix a lit test