chore(misc): minor recommendations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhthomas
reviewed
Jun 11, 2024
| switch level { | ||
| case "debug": | ||
| switch { | ||
| case strings.EqualFold(level, "debug"): |
There was a problem hiding this comment.
I like the intention, but do we really want to allow people to write LOG_LEVEL=dEbUg?
There was a problem hiding this comment.
Yeah, and "Debug" and all other permutations. My view is I'd rather avoid punishing the user for not reading the docs and completely adhering to the rules for less critical things like this. It reduces the support burden too. Ideally just supporting DEBUG or debug would be the most reasonable but EqualFold already exists and does that part too.
It does add a dependency which all else equal should be avoided but I think we can rely on "strings".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR not 100% intended to be merged, mostly just recommendations.