[WIP] Software Platform Modernization (tools) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nfrasser
commented
Dec 12, 2024
•
nfrasser
commented
- Drop python 3.7 support
- New and improved API client
- Formal model definitions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reached end-of-life over a year ago and no longer supported by our upcoming dependencies
* better type checking * additional related type fixes * additional logic and consistency fixes
Uses openapi schema to generate a client class Also includes - improved media type implementation for streams - better compatibility with fastapi - stub token model - first generated model from CryoSPARC. Other models will come later
- expose sort_params_schema
If given a list of enums, it should encode their values
Don't put these in query params or headers
Use model_validate instead of __init__ when parsing JSON from the API to ensure that special model validators which use a different type have their results intepreted correctly by pydantic
Interface remains largely the same, with some deprecations and changes to return values for asset endpoints * update unit tests to work with new api client: Mocks client functions rather than API requests. This is not the greatest, but mocking the HTTP requests would have been way more complicated * stream, dataset and type fixes * python 3.8 correct import and type issues * additional async dump stream helpers * update api and model types * initial changelog * improved stream protocol names * docstring updates and improvements * clear_cached_property for convenience
Move everything relevant into submodules, as per review feedback at #114 (comment)
* fix(tools): various bugs in new API integration * docs(tools): notebook fixes to work with updated APIs * docs(tools): README and CHANGELOG update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.