Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken code in custom latent trajectory example #70

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

PlethoraChutney
Copy link
Contributor

Working with Hannah, we found a few parts of this example that do not work. This version fixes those regions. Not sure if the fixed version of the dataset saving is still the right way to go though, was this written before save_external_result()?

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cryosparc-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 10:35pm

@PlethoraChutney
Copy link
Contributor Author

PlethoraChutney commented Dec 18, 2023

Sorry about that Nick, and sorry about a million commits here! In all of these cases, both the browser and VS Code were successfully showing the plot, and the <img> tag looked like it was still there, but not being rendered. I opted here to just save the image and include it as an attachment instead.

@nfrasser
Copy link
Member

No worries Rich, thanks for working out the kinks!

@nfrasser
Copy link
Member

Not sure if the fixed version of the dataset saving is still the right way to go though, was this written before save_external_result()?

Looks ok to me! Both save_external_result() and the save_output() strategy are valid. This strategy is nice because you can use alloc_output() to get a fresh empty dataset, which you can't do as easily with save_external_result()

@nfrasser nfrasser merged commit 5c9b4b3 into cryoem-uoft:develop Dec 19, 2023
11 checks passed
@PlethoraChutney PlethoraChutney deleted the custom-traj branch January 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants