Skip to content

Commit

Permalink
move return statement inside the loop
Browse files Browse the repository at this point in the history
  • Loading branch information
vincentysc committed Aug 2, 2024
1 parent 3a3da60 commit 5276fd9
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions usecase/parser/ibc/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -930,8 +930,6 @@ func ParseMsgTransfer(

if parserParams.IsEthereumTxInnerMsg {
events := log.GetEventsByType("send_packet")

var msgTransferParams ibc_model.MsgTransferParams
for _, event := range events {
// Transfer application, MsgTransfer
packetData := event.MustGetAttributeByKey("packet_data")
Expand All @@ -941,7 +939,7 @@ func ParseMsgTransfer(
panic("unable to parse `send_packet` event, key `packet_data`")
}

msgTransferParams = ibc_model.MsgTransferParams{
msgTransferParams := ibc_model.MsgTransferParams{
RawMsgTransfer: ibc_model.RawMsgTransfer{
Token: ibc_model.MsgTransferToken{
Denom: fungiblePacketData.Denom,
Expand All @@ -962,17 +960,17 @@ func ParseMsgTransfer(
ConnectionID: event.MustGetAttributeByKey("packet_connection"),
PacketData: fungiblePacketData,
}
}

// Getting possible signer address from Msg
var possibleSignerAddresses []string
possibleSignerAddresses = append(possibleSignerAddresses, msgTransferParams.Sender)
// Getting possible signer address from Msg
var possibleSignerAddresses []string
possibleSignerAddresses = append(possibleSignerAddresses, msgTransferParams.Sender)

return []command.Command{command_usecase.NewCreateMsgIBCTransferTransfer(
parserParams.MsgCommonParams,
return []command.Command{command_usecase.NewCreateMsgIBCTransferTransfer(

Check failure on line 968 in usecase/parser/ibc/msg.go

View workflow job for this annotation

GitHub Actions / lint

SA4004: the surrounding loop is unconditionally terminated (staticcheck)

Check failure on line 968 in usecase/parser/ibc/msg.go

View workflow job for this annotation

GitHub Actions / lint

SA4004: the surrounding loop is unconditionally terminated (staticcheck)
parserParams.MsgCommonParams,

msgTransferParams,
)}, possibleSignerAddresses
msgTransferParams,
)}, possibleSignerAddresses
}
}

event := log.GetEventByType("send_packet")
Expand Down

0 comments on commit 5276fd9

Please sign in to comment.