Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1075

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore: fix some comments #1075

merged 1 commit into from
Aug 15, 2024

Conversation

cuiweiyuan
Copy link
Contributor

fix some comments

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@cuiweiyuan cuiweiyuan requested a review from a team as a code owner August 8, 2024 07:21
@mmsqe
Copy link
Contributor

mmsqe commented Aug 8, 2024

Hi @cuiweiyuan, can you help to sign the commit?

Signed-off-by: cuiweiyuan <[email protected].>
@cuiweiyuan
Copy link
Contributor Author

Hi @cuiweiyuan, can you help to sign the commit?

Of course. Signed.

Please review again

@mmsqe mmsqe enabled auto-merge August 15, 2024 06:04
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.55%. Comparing base (9054a2d) to head (44edaf2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   34.34%   36.55%   +2.20%     
==========================================
  Files          93      101       +8     
  Lines       14105    14350     +245     
==========================================
+ Hits         4844     5245     +401     
+ Misses       8319     8158     -161     
- Partials      942      947       +5     
Flag Coverage Δ
integration_tests 25.79% <ø> (ø)
integration_tests_byzantine 11.27% <ø> (ø)
integration_tests_gov 11.54% <ø> (ø)
integration_tests_grpc 11.54% <ø> (ø)
integration_tests_ibc 27.52% <ø> (ø)
integration_tests_ledger 11.53% <ø> (ø)
integration_tests_slow 11.53% <ø> (ø)
integration_tests_solomachine 11.32% <ø> (ø)
integration_tests_upgrade ?
unit_tests 11.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe added this pull request to the merge queue Aug 15, 2024
Merged via the queue into crypto-org-chain:master with commit f7224d0 Aug 15, 2024
32 of 35 checks passed
mmsqe pushed a commit to kaz-CDC/chain-main that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants