Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: MsgModuleQuerySafe is not in allowed messages when upgrade #1084

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 11, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 36.52%. Comparing base (63c867d) to head (1b2ba8d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
app/upgrades.go 7.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   34.34%   36.52%   +2.18%     
==========================================
  Files          93      101       +8     
  Lines       14105    14360     +255     
==========================================
+ Hits         4844     5245     +401     
+ Misses       8319     8168     -151     
- Partials      942      947       +5     
Flag Coverage Δ
integration_tests 25.77% <14.28%> (-0.02%) ⬇️
integration_tests_byzantine 11.27% <14.28%> (-0.01%) ⬇️
integration_tests_gov 11.54% <14.28%> (-0.01%) ⬇️
integration_tests_grpc 11.54% <14.28%> (-0.01%) ⬇️
integration_tests_ibc 27.50% <14.28%> (-0.02%) ⬇️
integration_tests_ledger 11.52% <14.28%> (-0.01%) ⬇️
integration_tests_slow 11.52% <14.28%> (-0.01%) ⬇️
integration_tests_solomachine 11.31% <14.28%> (-0.01%) ⬇️
integration_tests_upgrade 11.54% <14.28%> (-0.01%) ⬇️
unit_tests 11.85% <14.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review October 14, 2024 01:23
@mmsqe mmsqe requested a review from a team as a code owner October 14, 2024 01:23
@mmsqe mmsqe added this pull request to the merge queue Oct 14, 2024
Merged via the queue into crypto-org-chain:master with commit 452e088 Oct 14, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants