Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: persist-credentials might leak github token unintentionally #1090

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 16, 2024

Solution:

  • try persist-credentials: false

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.23%. Comparing base (e92dda1) to head (404e443).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   34.23%   34.23%           
=======================================
  Files          93       93           
  Lines       14151    14151           
=======================================
  Hits         4844     4844           
  Misses       8365     8365           
  Partials      942      942           
Flag Coverage Δ
integration_tests 25.70% <ø> (ø)
integration_tests_byzantine 11.24% <ø> (ø)
integration_tests_gov 11.51% <ø> (ø)
integration_tests_grpc 11.51% <ø> (ø)
integration_tests_ibc 27.43% <ø> (ø)
integration_tests_ledger 11.49% <ø> (ø)
integration_tests_slow 11.49% <ø> (ø)
integration_tests_solomachine 11.28% <ø> (ø)
integration_tests_upgrade 11.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant