Merge pull request #118 from cryptoalgebra/after-pool-creation-hook

After pool creation hook

src/core/contracts/AlgebraFactory.sol

@@ -139,6 +139,14 @@ contract AlgebraFactory is IAlgebraFactory, Ownable2Step, AccessControlEnumerabl
 
     pool = IAlgebraPoolDeployer(poolDeployer).deploy(plugin, token0, token1, deployer);
 
+    if (deployer == address(0)) {
+      if (address(defaultPluginFactory) != address(0)) {
+        defaultPluginFactory.afterCreatePoolHook(plugin, pool, deployer);
+      }
+    } else {
+      IAlgebraPluginFactory(msg.sender).afterCreatePoolHook(plugin, pool, deployer);
+    }
+
     _poolByPair[token0][token1] = pool;
     _poolByPair[token1][token0] = pool;
 

src/core/contracts/interfaces/plugin/IAlgebraPluginFactory.sol

@@ -20,4 +20,10 @@ interface IAlgebraPluginFactory {
     address token1,
     bytes calldata data
   ) external returns (address);
+
+  /// @notice Called after the pool is created
+  /// @param plugin The plugin address
+  /// @param pool The address of the new pool
+  /// @param deployer The address of new plugin deployer contract (0 if not used)
+  function afterCreatePoolHook(address plugin, address pool, address deployer) external;
 }

src/core/contracts/test/MockCustomPoolCreator.sol

@@ -24,6 +24,8 @@ contract MockCustomPoolCreator is IAlgebraPluginFactory {
     emit BeforeCreateHook(pool, creator, deployer, token0, token1, data);
   }
 
+  function afterCreatePoolHook(address plugin, address pool, address deployer) external override {}
+
   function createCustomPool(address factory, address tokenA, address tokenB, bytes calldata data) external returns (address pool) {
     pool = IAlgebraFactory(factory).createCustomPool(address(this), msg.sender, tokenA, tokenB, data);
   }

src/core/contracts/test/MockDefaultPluginFactory.sol

@@ -9,6 +9,8 @@ import './MockPoolPlugin.sol';
 contract MockDefaultPluginFactory is IAlgebraPluginFactory {
   mapping(address => address) public pluginsForPools;
 
+  function afterCreatePoolHook(address plugin, address pool, address deployer) external override {}
+
   function beforeCreatePoolHook(address pool, address, address, address, address, bytes calldata) external override returns (address plugin) {
     plugin = address(new MockPoolPlugin(pool));
     pluginsForPools[pool] = plugin;

src/core/test/__snapshots__/AlgebraFactory.spec.ts.snap

@@ -1,13 +1,13 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`AlgebraFactory #createCustomPool gas [ @skip-on-coverage ] 1`] = `4833064`;
+exports[`AlgebraFactory #createCustomPool gas [ @skip-on-coverage ] 1`] = `4833685`;
 
-exports[`AlgebraFactory #createCustomPool gas for second pool [ @skip-on-coverage ] 1`] = `4833064`;
+exports[`AlgebraFactory #createCustomPool gas for second pool [ @skip-on-coverage ] 1`] = `4833685`;
 
-exports[`AlgebraFactory #createPool gas [ @skip-on-coverage ] 1`] = `4820775`;
+exports[`AlgebraFactory #createPool gas [ @skip-on-coverage ] 1`] = `4820932`;
 
-exports[`AlgebraFactory #createPool gas for second pool [ @skip-on-coverage ] 1`] = `4820775`;
+exports[`AlgebraFactory #createPool gas for second pool [ @skip-on-coverage ] 1`] = `4820932`;
 
-exports[`AlgebraFactory factory bytecode size  [ @skip-on-coverage ] 1`] = `10254`;
+exports[`AlgebraFactory factory bytecode size  [ @skip-on-coverage ] 1`] = `10609`;
 
 exports[`AlgebraFactory pool bytecode size  [ @skip-on-coverage ] 1`] = `22844`;

src/periphery/contracts/AlgebraCustomPoolEntryPoint.sol

@@ -50,6 +50,13 @@ contract AlgebraCustomPoolEntryPoint is IAlgebraCustomPoolEntryPoint {
         return IAlgebraPluginFactory(deployer).beforeCreatePoolHook(pool, creator, deployer, token0, token1, data);
     }
 
+    /// @inheritdoc IAlgebraPluginFactory
+    function afterCreatePoolHook(address plugin, address pool, address deployer) external override {
+        require(msg.sender == factory, 'Only factory');
+
+        IAlgebraPluginFactory(deployer).afterCreatePoolHook(plugin, pool, deployer);
+    }
+
     // ####### Permissioned actions #######
     // AlgebraCustomPoolEntryPoint must have a "POOLS_ADMINISTRATOR" role to be able to use permissioned actions
 

src/periphery/contracts/test/CustomPoolDeployerTest.sol

@@ -35,6 +35,10 @@ contract CustomPoolDeployerTest {
         return poolToPlugin[pool];
     }
 
+    function afterCreatePoolHook(address, address, address) external pure {
+        return;
+    }
+
     function setPluginForPool(address pool, address plugin) external {
         poolToPlugin[pool] = plugin;
     }

src/periphery/test/__snapshots__/NonfungiblePositionManager.spec.ts.snap

@@ -8,7 +8,7 @@ exports[`NonfungiblePositionManager #collect gas transfers token0 only [ @skip-o
 
 exports[`NonfungiblePositionManager #collect gas transfers token1 only [ @skip-on-coverage ] 1`] = `116994`;
 
-exports[`NonfungiblePositionManager #createAndInitializePoolIfNecessary gas [ @skip-on-coverage ] 1`] = `4812858`;
+exports[`NonfungiblePositionManager #createAndInitializePoolIfNecessary gas [ @skip-on-coverage ] 1`] = `4813015`;
 
 exports[`NonfungiblePositionManager #decreaseLiquidity gas complete decrease [ @skip-on-coverage ] 1`] = `167586`;
 

src/plugin/contracts/BasePluginV1Factory.sol

@@ -41,6 +41,11 @@ contract BasePluginV1Factory is IBasePluginV1Factory {
     return _createPlugin(pool);
   }
 
+  /// @inheritdoc IAlgebraPluginFactory
+  function afterCreatePoolHook(address, address, address) external view override {
+    require(msg.sender == algebraFactory);
+  }
+
   /// @inheritdoc IBasePluginV1Factory
   function createPluginForExistingPool(address token0, address token1) external override returns (address) {
     IAlgebraFactory factory = IAlgebraFactory(algebraFactory);

src/plugin/contracts/test/MockTimeDSFactory.sol

@@ -35,6 +35,11 @@ contract MockTimeDSFactory is IBasePluginV1Factory {
     return _createPlugin(pool);
   }
 
+  /// @inheritdoc IAlgebraPluginFactory
+  function afterCreatePoolHook(address, address, address) external view override {
+    require(msg.sender == algebraFactory);
+  }
+
   function createPluginForExistingPool(address token0, address token1) external override returns (address) {
     IAlgebraFactory factory = IAlgebraFactory(algebraFactory);
     require(factory.hasRoleOrOwner(factory.POOLS_ADMINISTRATOR_ROLE(), msg.sender));