Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmarks on merge queue, or manually #384

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

jschneider-bensch
Copy link
Collaborator

This PR introduces merge_queue triggers for all jobs that are run on PRs and makes it so that benchmarks are only run on the merge_queue event, or when manually triggered.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, but the ML-KEM / benchmarks are still enabled. Let's move them to the merge queue as well.

Also, I enabled the merge queue. So we'll see if this works.

@jschneider-bensch
Copy link
Collaborator Author

Sorry, I missed that somehow.

This was linked to issues Jul 10, 2024
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I also moved everything over to the new rulesets. Let's see if that's working.

@franziskuskiefer franziskuskiefer merged commit c3c9f17 into main Jul 10, 2024
45 checks passed
@franziskuskiefer franziskuskiefer deleted the jonas/queue-benchmarks branch July 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add merge queue Disable benchmarks on PRs
2 participants