Fix create new target_machine for every program
#14694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
|
What's the real difference? IIUC the original program was calling the getter, who was in turn creating an instance. EDIT: Answer to self: That isn't cached by the getter. |
beta-ziliani
approved these changes
Jun 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler#new_programinstantiates a newPrograminstance which is used for compiling a macrorunprogram. Some properties (such as codegen target) can be shared between multiple compilations. But theTargetMachineinstance must not be shared because this would leak potentially incompatible data layouts between programs.This patch creates a new instance of
TargetMachinefor every program.See #14496 (comment) and previous comments for details.
Resolves (probably) #14496