Add HashLiteral#has_key? and NamedTupleLiteral#has_key?
#14890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-gwozdz
force-pushed
the
add-has-key-to-macro-literals
branch
5 times, most recently
from
0443c58
to
6c29a7a
Compare
kamil-gwozdz
force-pushed
the
add-has-key-to-macro-literals
branch
2 times, most recently
from
ac66a97
to
523d482
Compare
kamil-gwozdz
force-pushed
the
add-has-key-to-macro-literals
branch
from
523d482
to
293da0b
Compare
kamil-gwozdz
force-pushed
the
add-has-key-to-macro-literals
branch
from
293da0b
to
e5f1187
Compare
|
Thanks for the PR! In the future, as called out in https://github.com/crystal-lang/crystal/blob/master/CONTRIBUTING.md#making-good-pull-requests, could you not force push? Doesn't matter too much in this case as it was a WIP branch, but it can make the review process harder if force pushes happen with pending comments and such. We squash merge PRs so no need to worry about having a lot of commits. |
Sija
reviewed
Aug 11, 2024
Sija
reviewed
Aug 11, 2024
Co-authored-by: Johannes Müller <[email protected]>
Co-authored-by: Johannes Müller <[email protected]>
straight-shoota
changed the title
has_key? to HashLiteral and NamedTupleLiteralHashLiteral#has_key? and NamedTupleLiteral#has_key?
Sija
approved these changes
Aug 12, 2024
straight-shoota
approved these changes
Aug 12, 2024
|
Thanks for the reviews. Unfortunately, i can't push to |
|
We'll merge the PR when it gets accepted. For that we still need an approval from another Core Team member. |
HertzDevil
reviewed
Aug 15, 2024
HertzDevil
reviewed
Aug 15, 2024
Co-authored-by: Quinton Miller <[email protected]>
ysbaddaden
approved these changes
Aug 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
HashLiteral#has_key?andNamedTupleLiteral#has_key?.closes #14841