Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LLVM::Builder#finalize #14892

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Add LLVM::Builder#finalize #14892

merged 3 commits into from
Aug 14, 2024

Conversation

JarnaChao09
Copy link
Contributor

Resolves #14861 using the second proposed solution: adding a finalize method to the LLVM::Builder class

@JarnaChao09 JarnaChao09 mentioned this pull request Aug 12, 2024
Open
@straight-shoota
Copy link
Member

The spec failure on Windows is a fluke and unrelated to this PR.

@straight-shoota straight-shoota changed the title Add finalize method to LLVM::Builder Add LLVM::Builder#finalize Aug 12, 2024
@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 13, 2024
@straight-shoota straight-shoota merged commit 7cee884 into crystal-lang:master Aug 14, 2024
62 checks passed
@JarnaChao09 JarnaChao09 deleted the feature/dispose-builder branch August 15, 2024 05:46
@BrewTestBot BrewTestBot mentioned this pull request Oct 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:llvm
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

LLVM::Builder cannot be disposed
4 participants
@JarnaChao09 @straight-shoota @ysbaddaden @Blacksmoke16