Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract select from src/channel.cr #14912

Merged

Conversation

straight-shoota
Copy link
Member

select is an independent feature and not directly related to Channel (although sending/receiving from Channel is its main purpose).
This patch extracts the implementation of select actions from channel.cr into separate files.
It's a purely organizational refactor and does not involve any semantic changes. Everything stays in the Channel namespace.

This is a preparatory step to make it easier to work on the code by separating concerns.

Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it helps to focus on each concern 👍

@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 17, 2024
@straight-shoota straight-shoota merged commit 75ced20 into crystal-lang:master Aug 18, 2024
65 checks passed
@straight-shoota straight-shoota deleted the refactor/select-files branch August 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants