Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for linker flag sub commands #14932

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Add error handling for linker flag sub commands #14932

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67941f9
Add error handling for linker flag sub commands
straight-shoota Aug 22, 2024
f96e42c
Update src/compiler/crystal/compiler.cr
straight-shoota Aug 22, 2024
8f07e06
Use `IO::Memory#to_s` directly
straight-shoota Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/compiler/crystal/compiler.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,24 @@ module Crystal
if program.has_flag? "msvc"
lib_flags = program.lib_flags
# Execute and expand `subcommands`.
lib_flags = lib_flags.gsub(/`(.*?)`/) { `#{$1}` } if expand
if expand
lib_flags = lib_flags.gsub(/`(.*?)`/) do
command = $1
begin
error_io = IO::Memory.new
output = Process.run(command, shell: true, output: :pipe, error: error_io) do |process|
process.output.gets_to_end
end
unless $?.success?
error_io.rewind
error "Error executing subcommand for linker flags: #{command.inspect}: #{error_io}"
end
output
rescue exc
error "Error executing subcommand for linker flags: #{command.inspect}: #{exc}"
end
end
end

object_arg = Process.quote_windows(object_names)
output_arg = Process.quote_windows("/Fe#{output_filename}")
Expand Down
Loading