Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #file_descriptor_close should set @closed (UNIX) #14973

Conversation

ysbaddaden
Copy link
Contributor

Extracted from #14959 that outlined the issue as the GC tried to cleanup resources that had already be closed in signal/process pipes.

@ysbaddaden ysbaddaden added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system labels Sep 5, 2024
@ysbaddaden ysbaddaden self-assigned this Sep 5, 2024
@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 5, 2024
@straight-shoota straight-shoota merged commit 025f3e0 into crystal-lang:master Sep 6, 2024
59 of 61 checks passed
@ysbaddaden ysbaddaden deleted the fix/file_descriptor_close-must-set-closed branch September 6, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants