Support directory name in -o CLI option
#15471
Open
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
feat/cli-output_path-dir
branch
3 times, most recently
from
592d771 to
729af58
Compare
straight-shoota
force-pushed
the
feat/cli-output_path-dir
branch
from
729af58 to
217633e
Compare
ysbaddaden
approved these changes
Feb 20, 2025
| @@ -139,7 +139,7 @@ Disable colored output. | |||
| .It Fl -no-codegen | |||
| Don't do code generation, just parse the file. | |||
| .It Fl o | |||
| Specify filename of output. | |||
| Specify output path. If a directory, the filename is derived from the first source file (default: ./) | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| Specify output path. If a directory, the filename is derived from the first source file (default: ./) | |
| Specify output path. If a directory, the filename is derived from the first source file (default is the current directory) |
Same in command.cr.
There was a problem hiding this comment.
I'd think ./ should be clearly understandable as a reference to the current directory? Then this is just more words to say the same thing.
Do you have any concerns that ./ would not be understood correctly?
There was a problem hiding this comment.
I understand better the "current directory" words in a text than "./" which is first odd and then I understand "oh, dot, the current directory".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15443