Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eigenvalue page #10

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Update eigenvalue page #10

merged 13 commits into from
Feb 23, 2024

Conversation

pascaladhikary
Copy link
Collaborator

  • reorganize in slide order
  • include finding eval/evec example, code snippet
  • replace cost summary with cost/convergence table

@pascaladhikary pascaladhikary self-assigned this Feb 12, 2024
@pascaladhikary pascaladhikary requested a review from a team as a code owner February 12, 2024 01:12
Copy link
Collaborator

@jlevine18 jlevine18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good start- see my comments. i'd also take a bit of a closer look at some of the power iteration section that we currently have and give a little more to help students build intuition- we ask a lot of questions about errors/convergence/advantage of normalization, which the notes are somewhat lacking in. i'd also add a couple graphical examples as well to show eigenvals/eigenvecs as deformation directions, and convergence during the steps of power iteration. i'd also look into moving some stuff around in the power-iteration section and making that the whole text is cohesive and reads well. feel free to do things a little differently- the most important goals are that the material contains everything someone might need to do hw/a quiz and that it reads well

notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
notes/eigen.md Outdated Show resolved Hide resolved
@jlevine18
Copy link
Collaborator

also it's probably worth doing one last check to make sure that everything from the slides/videos is in here

Copy link
Collaborator

@jlevine18 jlevine18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good- thanks for your help

@devksingh4 devksingh4 merged commit 3dd9a5e into main Feb 23, 2024
1 check passed
@devksingh4 devksingh4 deleted the pascal-eigval branch February 23, 2024 19:41
Copy link
Member

@devksingh4 devksingh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants