-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eigenvalue page #10
Conversation
pascaladhikary
commented
Feb 12, 2024
- reorganize in slide order
- include finding eval/evec example, code snippet
- replace cost summary with cost/convergence table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good start- see my comments. i'd also take a bit of a closer look at some of the power iteration section that we currently have and give a little more to help students build intuition- we ask a lot of questions about errors/convergence/advantage of normalization, which the notes are somewhat lacking in. i'd also add a couple graphical examples as well to show eigenvals/eigenvecs as deformation directions, and convergence during the steps of power iteration. i'd also look into moving some stuff around in the power-iteration section and making that the whole text is cohesive and reads well. feel free to do things a little differently- the most important goals are that the material contains everything someone might need to do hw/a quiz and that it reads well
also it's probably worth doing one last check to make sure that everything from the slides/videos is in here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good- thanks for your help
88e4201
to
a83c6d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm