Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SVD #35

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Update SVD #35

merged 6 commits into from
Apr 18, 2024

Conversation

pascaladhikary
Copy link
Collaborator

  • move summary up into an overview, write a little about the intuition, make it a little more concise since I found certain things were repeated 3-4 times
  • Model proofs closer to the slides
  • Add explanation of ATA and AAT being positive semi-definite
  • Add solving square linear systems section
  • Introduce review questions, update changeling

@pascaladhikary pascaladhikary requested a review from a team as a code owner April 5, 2024 20:29
@pascaladhikary pascaladhikary requested a review from jlevine18 April 5, 2024 20:29
jlevine18
jlevine18 requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@jlevine18 jlevine18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good already- maybe include a bit more from the application slides. Thank you so much for everything so far.

notes/svd.md Outdated Show resolved Hide resolved
notes/svd.md Show resolved Hide resolved
jlevine18
jlevine18 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@jlevine18 jlevine18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devksingh4 devksingh4 merged commit 6cb48e9 into main Apr 18, 2024
1 check passed
@devksingh4 devksingh4 deleted the pascal-svd branch April 29, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlevine18 jlevine18 jlevine18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pascaladhikary @jlevine18 @devksingh4