Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Relative Paths in 404 Page by Skipping Post-Render Process #195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zivmax
Copy link

@zivmax zivmax commented Jan 22, 2025

This pull request addresses the issue where relative paths in the 404 page (404.md or 404.html) are incorrectly resolved for non-root URLs. The fix ensures that the 404 page uses absolute paths for assets by skipping the post-render process for these files.

Changes

  • Skip the post-render process for 404.md or 404.html to prevent incorrect relative path resolution.

Impact

  • Fixes the issue where accessing non-existent URLs at deeper levels (e.g., /non/exist) caused assets to fail to load.

Related Issue

Closes #194.

@dmalan dmalan self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative Paths in Custom 404 Page Not Resolving Correctly for Non-Root URLs
2 participants