Fix need for rust/cargo when installing, allow jellyfish 1.1.3 with prebuilt wheels #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current install requirements forces the use of jellyfish 0.11.3, for which there are no prebuilt wheels for macOS (which means installation requires downloading rust/cargo). Jellyfish 1.1.3 has prebuilt macos wheels, and does not change jaro_wrinkler() so allowing 1.1.3 makes installing lib50 and others more straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in cs50/submit50#364,
pip3 install submit50or installing anything usinglib50gives an error requiring rust/cargo to be installed.This is because
setup.pyenforces jellyfish versionsjellyfish>=0.7,<1, which defaults tojellyfish 0.11.3. There are no prebuilt wheels for forjellyfish 0.11.3, so pip says you need to get rust/cargo to buildjellyfish.The fix allows versions
jellyfish>=0.7,<2(currently defaults to 1.1.3) which has prebuilt macos wheels, and does not change jaro_wrinkler()