Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDA5807M.h #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update RDA5807M.h #5

wants to merge 1 commit into from

Conversation

messere63
Copy link

set volume to a defined value

Copy link
Owner

@csdexter csdexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there and thanks for the pull request :-)
I believe you wanted "bool setVolume(byte newVolume);" instead of "bool volumeUp(byte);" here. The documentation comment should also follow the format used for the other methods.

Otherwise, I'm happy with this change and will merge as soon as the issue noted above is fixed.

@csdexter csdexter self-assigned this Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants