Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement k anonymity (#45) #45

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Conversation

stellaljung
Copy link
Collaborator

No description provided.

@stellaljung stellaljung linked an issue Dec 11, 2023 that may be closed by this pull request
@stellaljung stellaljung added this to the Sprint 3 milestone Dec 11, 2023
ni-jessica
ni-jessica previously approved these changes Dec 11, 2023
backend/src/main.cpp Outdated Show resolved Hide resolved
backend/src/server.cpp Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@csirianni csirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I checked with tests and manually and it looks correct to me. I've got some questions and suggestions about implementation details. Also, this code should probably be refactored to a separate source file so we can unit test and make main.cpp less busy. But that is for a future issue!

backend/src/main.cpp Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
backend/tests/server.cpp Outdated Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
backend/tests/server.cpp Show resolved Hide resolved
backend/src/server.cpp Outdated Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
ni-jessica
ni-jessica previously approved these changes Dec 12, 2023
@ni-jessica ni-jessica changed the title 44 implement k anonymity feat: implement k anonymity (#44) Dec 12, 2023
@ni-jessica ni-jessica changed the title feat: implement k anonymity (#44) feat: implement k anonymity (#45) Dec 12, 2023
@stellaljung stellaljung merged commit 9e14cb2 into main Dec 12, 2023
3 checks passed
@stellaljung stellaljung deleted the 44-implement-k-anonymity branch December 12, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement k-anonymity
3 participants