Symfony 7 #1248
Draft
Symfony 7 #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopelijk werkt CI nu wel... Oeps Okay, hopelijk zijn de fixtures nu echt gefixt...
NathanHuisman
force-pushed
the
symfony7
branch
2 times, most recently
from
2fddfd6 to
7085561
Compare
NathanHuisman
force-pushed
the
symfony7
branch
from
7085561 to
db9588f
Compare
|
NathanHuisman
commented
Feb 8, 2025
There was a problem hiding this comment.
De meeste veranderingen zijn vooral $this->_em -> $this->getEntityManager() en Security\Core -> SecurityBundle. Beetje vervelend om hier doorheen te spitten, maar ja.
Verder nog wat dingetjes over het hoofd gezien en moet ook nog werken aan database migrations + fixtures
| @@ -182,3 +182,5 @@ services: | |||
| CsrDelft\common\Security\Voter\: | |||
| resource: '../lib/common/Security/Voter' | |||
|
|
|||
| Doctrine\Common\Annotations\Reader: | |||
There was a problem hiding this comment.
Kunnen we dit niet weghalen?
| @@ -14,9 +14,6 @@ doctrine: | |||
|
|
|||
| url: '%env(resolve:DATABASE_URL)%' | |||
| types: | |||
| date: CsrDelft\common\Doctrine\Type\DateImmutableType | |||
| datetime: CsrDelft\common\Doctrine\Type\DateTimeImmutableType | |||
| datetimetz: CsrDelft\common\Doctrine\Type\DateTimeTzImmutableType | |||
| time: Doctrine\DBAL\Types\TimeImmutableType | |||
| public function getSupportedTypes(?string $format): array | ||
| { | ||
| return [ | ||
| "object" => true |
There was a problem hiding this comment.
Nog niet helemaal bekend met de semantics hiervan
| @@ -91,7 +91,7 @@ public function saveVrijstelling( | |||
| DateTimeInterface $eind, | |||
| $percentage | |||
| ) { | |||
| return $this->_em->transactional(function () use ( | |||
| return $this->getEntityManager()->transactional(function () use ( | |||
There was a problem hiding this comment.
Dit moet wrapInTransaction zijn
| @@ -11,6 +11,7 @@ | |||
| use CsrDelft\view\formulier\knoppen\FormDefaultKnoppen; | |||
| use CsrDelft\view\formulier\ModalForm; | |||
| use Exception; | |||
| use Twig\Environment; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP voor Symfony 7 + Doctrine ORM 3