Supports CoreProperties with No Namespace #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to this old PR: #20
The CoreProperties element can sometimes have its namespace defined as a default namespace (I've encountered some such word documents). See the defaul namespaces section here, along with the example docx file I have added to the pandocs folder.
This change just adds a CoreNoNamespace alternative which handles the missing namespace tag
Note that CoreNoNamespace implements to_writer the same exact way as CoreNamespace (namely, it writes the XML with the namespace). This is for simplicity, since there is no harm in writing the XML back out with the namespace defined in the usual fashion.