Cleaning the categories for alpha agenda #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #885 +/- ##
===========================================
- Coverage 13.57% 13.44% -0.14%
===========================================
Files 439 439
Lines 3117 3110 -7
===========================================
- Hits 423 418 -5
+ Misses 2694 2692 -2 ☔ View full report in Codecov by Sentry. |
lodewiges
changed the title
|
can you ask someone else to review this? Maybe Maarten or Jesse? |
|
nvm I have already left my thoughts on csvalpha/amber-api#438 |
DrumsnChocolate
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
If we decide not to follow the route of what I'm suggesting in csvalpha/amber-api#438 (comment), then this is approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combining dinsdag kring and woensdag kring in 1 category because all kringen are on Tuesday.
NEED TO BE MERGED AT THE SAME TIME
fixes #861 and #685
depended on csvalpha/amber-api#438