Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master in to staging #1001

Closed
wants to merge 33 commits into from
Closed

merge master in to staging #1001

wants to merge 33 commits into from

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Jan 14, 2025

this is only to see te merge conflict
i think we made a mistake last time when manualy merging staging into master which lead to this mess

github-actions bot and others added 3 commits February 7, 2024 20:30
* chore(deps): update dependency paranoia to v3 (#931)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Edited the env file (#944)

* edited the env file

* changed company name to UTF-8

* chore(deps): update dependency puma to '~> 6.4.0' [security] (#935)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/delete-package-versions action to v5 (#906)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency rails to v7.0.8.1 [security] (#918)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/build-push-action action to v6 (#928)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/login-action action to v3 (#886)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(tests): add code coverage reporting (#891)

* feat(tests): add code coverage reporting

* fix: correct coverage path

* refactor: use simplecov-lcov

* fix: indentation in Gemfile.lock

* fix: remove test filters

* feat(README): add badge

* refactor: try tokenless report uploading

* chore: update codecov-action

* chore: update codecov-action

* fix(cd): pass CODECOV_TOKEN To ci

* Revert "chore(deps): update docker/login-action action to v3 (#886)" (#951)

This reverts commit d546681. due to CI failure

* chore(deps): update codecov/codecov-action action to v5 (#950)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency puma to v6.4.3 [security] (#948)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact action to v4 (#949)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Refractor/tomato to sofia (#947)

* Intial commit

* updated apliction.rb

* Fixed mistake in credentials

* Made it so the file is backwards compatiable

* Fixed a typo

* Update amber_oauth2.rb

remove tomato paramater

* Remove development title lux ad mosam (#946)

* intial commit

* Fix typo

* update tomato to sofia

* updated with suggestion

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: lodewiges <[email protected]>
Co-authored-by: Guido de Jong <[email protected]>
due to the CD in master referring to the CI in staging. you will get an error when changing the secrets. I open an issue to fix it permanently.
#999
@lodewiges lodewiges marked this pull request as draft January 14, 2025 00:33
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (staging@465dc99). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/omniauth/strategies/amber_oauth2.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             staging    #1001   +/-   ##
==========================================
  Coverage           ?   52.37%           
==========================================
  Files              ?       55           
  Lines              ?     1178           
  Branches           ?        0           
==========================================
  Hits               ?      617           
  Misses             ?      561           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lodewiges lodewiges added the critical Dit moet gefixt vóór de volgende borrel label Jan 14, 2025
@lodewiges lodewiges closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Dit moet gefixt vóór de volgende borrel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants