Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes contious delivery #945

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Fixes contious delivery #945

merged 12 commits into from
Jan 19, 2025

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Nov 12, 2024

fixes #943

@lodewiges lodewiges changed the title Fixes contious delivery and prepare for codecov Fixes contious delivery Nov 24, 2024
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (staging@465dc99). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             staging     #945   +/-   ##
==========================================
  Coverage           ?   75.17%           
==========================================
  Files              ?       55           
  Lines              ?     1116           
  Branches           ?        0           
==========================================
  Hits               ?      839           
  Misses             ?      277           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue you referenced is rather non-descript, so I don't know why we're doing this, but go ahead

Comment on lines +62 to 63
INPUT_MERGE: ${{ inputs.merge }}
TARGET_ENV: ${{ github.event.inputs.target_env }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the modification for one and not the other?

@lodewiges lodewiges added this pull request to the merge queue Jan 19, 2025
Merged via the queue into staging with commit 62b9058 Jan 19, 2025
5 checks passed
@lodewiges lodewiges deleted the fix/CD branch January 19, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit CD just like amber-ui
2 participants