Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reco gamma selection #185

Merged
merged 3 commits into from
May 12, 2022
Merged

Fix reco gamma selection #185

merged 3 commits into from
May 12, 2022

Conversation

mikael10j
Copy link
Collaborator

solves #184

@mikael10j mikael10j requested a review from vuillaut April 8, 2022 14:09
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #185 (3c59cfd) into master (eafbe37) will increase coverage by 0.03%.
The diff coverage is 31.34%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   63.15%   63.19%   +0.03%     
==========================================
  Files          21       21              
  Lines        2717     2733      +16     
==========================================
+ Hits         1716     1727      +11     
- Misses       1001     1006       +5     
Impacted Files Coverage Δ
ctaplot/gammaboard/reader.py 0.00% <0.00%> (ø)
ctaplot/plots/style.py 100.00% <ø> (ø)
ctaplot/gammaboard/gammaboard.py 11.81% <2.27%> (-0.10%) ⬇️
ctaplot/ana/ana.py 88.20% <85.71%> (-0.03%) ⬇️
ctaplot/__init__.py 100.00% <100.00%> (ø)
ctaplot/ana/tests/test_ana.py 100.00% <100.00%> (ø)
ctaplot/plots/plots.py 78.46% <100.00%> (ø)
ctaplot/plots/tests/test_plots.py 98.73% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b610a0...3c59cfd. Read the comment docs.

@vuillaut vuillaut merged commit 0db3eae into master May 12, 2022
@vuillaut vuillaut deleted the gammaness_cut branch May 12, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants