Multiple quantiles for angular_resolution #290
Conversation
| quantile = [quantile] | ||
|
|
||
| if len(quantile) < 2: | ||
| keys = ["angular_resolution"] |
There was a problem hiding this comment.
I think it's somewhat confusing to change the naming of the output key based on the number of quantiles. Just having a single valuye doesn't mean that that value is what should be defined as "angular resolution" (which is often defined as either 68% containment or 90% containment in different cases). Wouldn't it be better to just always call them containment_quantile_XX in all cases? or if you really want to be specific, something like angular_resolution_{value*100:.0f}pct_containment. That way there is no surprise to the user that the column names change.
I guess the issue is that somewhere else, the code looks for a magic column named "angular_resolution", but then it's also better to make that column name configurable, and have it default to the CTAO standard using the more explicit column naming.
This makes it possible to pass multiple values to the
quantileargument ofpyirf.benchmarks.angular_resolution.If done so, all the quantiles will be calculated and if only one quantile is passed (default), the output is the same as before.