Made citations easier to copy #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -390,6 +390,21 @@ h6 { | |||
| padding: 10px; | |||
| } | |||
|
|
|||
| /* Citation modal popup stuff */ | |||
|
|
|||
| textarea { | |||
There was a problem hiding this comment.
Right now this is applying to all textareas. Is that bad?
- The individual publication pages now use the same citation popup as the publications index. - The citation popup uses readonly textareas so the text is easily selectable. - There is a "Select All" button to make text selection even easier.
tbekolay
force-pushed
the
pub-upgrades
branch
3 times, most recently
from
55c6dc4 to
81b234a
Compare
|
Apologies, this is super old now! But, I took a look and made a slightly different version. It's similar in concept, but makes less changes to the style of the modal. Instead of a "select all" button, now the citation text is clickable (has a pointer cursor on hover) and when you click it it selects all the text for easy copying. And yeah, at this point Bootstrap 4 is out, so we should upgrade. It's a lot to change though. |
|
Since it's so old I don't know if it'll be easy to review, so yeah, I'll probably just merge this in a bit. |
tbekolay
force-pushed
the
pub-upgrades
branch
3 times, most recently
from
34c13f1 to
4d8ee56
Compare
Instead of using a textarea, we make the div containing the citation select on click. Also, fixed some issues with including two copies of jquery and bootstrap, which were causing the modal to fire twice. This commit also introduces a `main.js` file for keeping together miscellaneous JS that is used on multiple pages.
|
I don't remember this much at all, so if you say it's good to go I'll take your word for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the publications index.
selectable.
Together, these features help address #36.
I added some scripts (JQuery and Bootstrap.js) so I wanted to run this by @tbekolay. Also, would it be possible to upgrade to newer Bootstrap? I think this might make some of the things I'm doing easier and less hackish (namely since I could get the calling button/link for setting the popup tab).
There's some inline style elements that should maybe be in our .css file? Is that an issue?