sync @google-cloud/storage package used across packages

cube-js · Sep 27, 2024 · 67ea07a · 67ea07a
1 parent 1b714d5
commit 67ea07a
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 203 deletions.
diff --git a/packages/cubejs-base-driver/package.json b/packages/cubejs-base-driver/package.json
@@ -29,11 +29,11 @@
     "dist/src/*"
   ],
   "dependencies": {
-    "@azure/storage-blob": "^12.9.0",
     "@aws-sdk/client-s3": "^3.49.0",
     "@aws-sdk/s3-request-presigner": "^3.49.0",
+    "@azure/storage-blob": "^12.9.0",
     "@cubejs-backend/shared": "^0.36.0",
-    "@google-cloud/storage": "^5.8.5",
+    "@google-cloud/storage": "^7.13.0",
     "ramda": "^0.27.0"
   },
   "devDependencies": {

diff --git a/packages/cubejs-bigquery-driver/package.json b/packages/cubejs-bigquery-driver/package.json
@@ -32,7 +32,7 @@
     "@cubejs-backend/dotenv": "^9.0.2",
     "@cubejs-backend/shared": "^0.36.0",
     "@google-cloud/bigquery": "^7.7.0",
-    "@google-cloud/storage": "^7.11.1",
+    "@google-cloud/storage": "^7.13.0",
     "ramda": "^0.27.2"
   },
   "devDependencies": {

diff --git a/packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts b/packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts
@@ -331,9 +331,6 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
     );
   }
 
-  /**
-   * @todo Move to BaseDriver in the future?
-   */
   protected getExportBucket(
     dataSource: string,
   ): SnowflakeDriverExportBucket | undefined {