feat: new methods for step-by-step db schema fetching #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7058 +/- ##
===========================================
- Coverage 86.33% 47.04% -39.30%
===========================================
Files 151 155 +4
Lines 32445 20715 -11730
Branches 0 5213 +5213
===========================================
- Hits 28013 9745 -18268
- Misses 4432 10653 +6221
- Partials 0 317 +317
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MikeNitsenko
commented
Aug 23, 2023
MikeNitsenko
commented
Aug 23, 2023
MikeNitsenko
force-pushed
the
CC-2172-new-methods-for-step-by-step-db-schema-fetching
branch
from
45a6482
to
5773564
Compare
MikeNitsenko
requested review from
ovr and
paveltiunov
and removed request for
a team
ovr
reviewed
Sep 1, 2023
ovr
reviewed
Sep 1, 2023
ovr
reviewed
Sep 1, 2023
MikeNitsenko
commented
Sep 6, 2023
MikeNitsenko
commented
Sep 6, 2023
MikeNitsenko
force-pushed
the
CC-2172-new-methods-for-step-by-step-db-schema-fetching
branch
2 times, most recently
from
04e3ef6
to
9ccd5ef
Compare
MikeNitsenko
force-pushed
the
CC-2172-new-methods-for-step-by-step-db-schema-fetching
branch
from
df9d277
to
4e10428
Compare
ovr
reviewed
Sep 13, 2023
ovr
reviewed
Sep 15, 2023
packages/cubejs-testing-drivers/src/tests/testIncrementalSchemaLoading.ts
Outdated
Show resolved
Hide resolved
ovr
reviewed
Sep 15, 2023
packages/cubejs-testing-drivers/src/tests/testIncrementalSchemaLoading.ts
Outdated
Show resolved
Hide resolved
ovr
reviewed
Sep 15, 2023
packages/cubejs-testing-drivers/src/tests/testIncrementalSchemaLoading.ts
Outdated
Show resolved
Hide resolved
MikeNitsenko
deleted the
CC-2172-new-methods-for-step-by-step-db-schema-fetching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
BaseDriverto retrieve schemas list, tables list for specific schemas, columns list for specific tablesincrementalSchemaLoading: true | false- to indicate whether the driver supports these features or notDrivers that support this implementation