Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native): Init logger earlier without javascript side (silient err… #7228

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(native): Init logger earlier without javascript side (silient err… #7228

merged 1 commit into from
Oct 19, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Oct 16, 2023

Hello!

Thanks

@ovr ovr requested review from a team as code owners October 16, 2023 15:10
@ovr ovr requested review from MazterQyou and removed request for a team October 16, 2023 15:10
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 4:39pm

@ovr ovr requested a review from paveltiunov October 16, 2023 15:10
@ovr ovr force-pushed the fix/native-logger-initialization-printing branch from 29f148f to 5d957e5 Compare October 16, 2023 15:41
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (abf5a0c) 47.05% compared to head (95a554f) 71.19%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7228       +/-   ##
===========================================
+ Coverage   47.05%   71.19%   +24.14%     
===========================================
  Files         155      323      +168     
  Lines       20752    53787    +33035     
  Branches     5219     5219               
===========================================
+ Hits         9765    38296    +28531     
- Misses      10669    15173     +4504     
  Partials      318      318
Flag Coverage Δ
cube-backend 47.05% <ø> (ø)
cubesql 86.36% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rust/cubesql/cubesql/e2e/main.rs 91.66% <100.00%> (ø)
rust/cubesql/cubesql/src/bin/cubesqld.rs 0.00% <0.00%> (ø)
rust/cubesql/cubesql/src/telemetry/mod.rs 73.52% <66.66%> (ø)

... and 165 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr
fix(native): Init logger earlier without javascript side (silient err…
95a554f 
…ors)

chore: fmt

chore: fmt

chore: fmt

chore: fix tests
@ovr ovr force-pushed the fix/native-logger-initialization-printing branch from d4b6134 to 95a554f Compare October 19, 2023 16:38
@ovr ovr merged commit 1f6d49d into master Oct 19, 2023
67 checks passed
@ovr ovr deleted the fix/native-logger-initialization-printing branch October 19, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazterQyou MazterQyou Awaiting requested review from MazterQyou

@paveltiunov paveltiunov Awaiting requested review from paveltiunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ovr