Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubejs-api-gateway): Support returning new security context from check_auth #8585

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Aug 14, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#8133

Description of Changes Made (if issue reference is not provided)

This is useful with Python configs, where input checkAuth context is a copy of original context

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:41pm

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (1afa934) to head (fa1a97b).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8585      +/-   ##
==========================================
- Coverage   82.56%   82.56%   -0.01%     
==========================================
  Files         209      209              
  Lines       77011    77011              
==========================================
- Hits        63585    63581       -4     
- Misses      13426    13430       +4     
Flag Coverage Δ
cubesql 82.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mcheshkov and others added 3 commits August 27, 2024 01:36
… check_auth

This is useful with Python configs, where it's input checkAuth context is a copy of original context
@mcheshkov mcheshkov merged commit 704a96c into master Aug 28, 2024
69 checks passed
@mcheshkov mcheshkov deleted the check-auth-py-modify-ctx branch August 28, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants