Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Introduce max sessions limit #8616

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Aug 22, 2024

No description provided.

@ovr ovr requested a review from a team as a code owner August 22, 2024 14:42
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:24pm

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.54%. Comparing base (03277b0) to head (57c402e).
Report is 1 commits behind head on master.

Files Patch % Lines
rust/cubesql/cubesql/src/sql/postgres/service.rs 7.69% 12 Missing ⚠️
rust/cubesql/cubesql/src/sql/session_manager.rs 40.00% 6 Missing ⚠️
rust/cubesql/pg-srv/src/protocol.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8616      +/-   ##
==========================================
- Coverage   82.57%   82.54%   -0.03%     
==========================================
  Files         209      209              
  Lines       77025    77049      +24     
==========================================
+ Hits        63600    63602       +2     
- Misses      13425    13447      +22     
Flag Coverage Δ
cubesql 82.54% <40.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the chore/cubesql-max-sessions-limit branch from e6e2788 to 78ce33b Compare August 27, 2024 17:41
err.to_string(),
);

if let Err(err) = buffer::write_message(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ovr ovr merged commit dfcb596 into master Aug 27, 2024
65 checks passed
@ovr ovr deleted the chore/cubesql-max-sessions-limit branch August 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants