fix(cubesql): Don't clone response, improve performance #8638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
ovr
commented
Aug 26, 2024
| #[cfg(debug_assertions)] | ||
| trace!("[transport] Request <- {:?}", response); | ||
| #[cfg(not(debug_assertions))] | ||
| trace!("[transport] Request <- <hidden>"); | ||
|
|
||
| let load_err = match serde_json::from_value::<TransportLoadResponse>(response.clone()) { |
There was a problem hiding this comment.
serde_json::from_value requires passing the own of the value; it's why we used clone here. The biggest problem is that we used it for successful responses, which is a large structure.
PR fixes that issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8638 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 209 209
Lines 76718 76718
=======================================
Hits 63300 63300
Misses 13418 13418
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde_json::from_value requires passing the own of the value; it's why we used
clonehere. The biggest problem is that we used it for successful responses, which is a large structure.PR fixes that issue.