refactor(cubesql): Use LazyLock instead of lazy_static, move more regexps to statics #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beScanWrapperNode
…n egraph converter
…s lattice in rewrite rules
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8675 +/- ##
==========================================
+ Coverage 82.55% 82.56% +0.01%
==========================================
Files 209 209
Lines 77054 77095 +41
==========================================
+ Hits 63611 63653 +42
+ Misses 13443 13442 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
more-lazy-statics
branch
from
353b708
to
263ec6f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
ovr
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Rust 1.80.0 introduced
std::sync::LazyLock, which is intended to replacelazy_staticcrate.https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html
This PR replaces all of
lazy_staticinstances with eitherLazyLockorstd::sync::Once, and moves some staticRegexinstances to LazyLock as well.