refactor(cubesql): Make Postgres authentication extensible #8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8709 +/- ##
==========================================
- Coverage 82.62% 82.61% -0.02%
==========================================
Files 212 213 +1
Lines 77343 77407 +64
==========================================
+ Hits 63906 63949 +43
- Misses 13437 13458 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MazterQyou
force-pushed
the
cubesql/auth-methods
branch
from
fb9ba98
to
9cd13af
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
force-pushed
the
cubesql/auth-methods
branch
3 times, most recently
from
b06862d
to
b3a13ec
Compare
MazterQyou
force-pushed
the
cubesql/auth-methods
branch
from
b3a13ec
to
f79fff6
Compare
ovr
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR refactors pg-srv, making authentication request methods and message tag parsing to be extendable. It also adds
PostgresAuthServiceto be able to extend the auth process.