Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cubesql): Extract some join tests to separate module #8777

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (0f974ae) to head (8b545e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8777      +/-   ##
==========================================
- Coverage   82.66%   82.66%   -0.01%     
==========================================
  Files         218      219       +1     
  Lines       78127    78127              
==========================================
- Hits        64586    64581       -5     
- Misses      13541    13546       +5     
Flag Coverage Δ
cubesql 82.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 4, 2024 15:38
@mcheshkov mcheshkov requested a review from a team as a code owner October 4, 2024 15:38
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 10:45pm

@mcheshkov mcheshkov merged commit e49b5f5 into master Oct 4, 2024
71 checks passed
@mcheshkov mcheshkov deleted the extract-join-tests branch October 4, 2024 23:26
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants