Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cubesql): Extract some wrapper tests to separate module #8783

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 4:09pm

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 98.65017% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (893004a) to head (936fc30).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 98.64% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8783      +/-   ##
==========================================
- Coverage   82.67%   82.66%   -0.01%     
==========================================
  Files         217      218       +1     
  Lines       78125    78127       +2     
==========================================
- Hits        64588    64586       -2     
- Misses      13537    13541       +4     
Flag Coverage Δ
cubesql 82.66% <98.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 4, 2024 17:46
@mcheshkov mcheshkov requested a review from a team as a code owner October 4, 2024 17:46
@mcheshkov mcheshkov merged commit 0f974ae into master Oct 4, 2024
83 checks passed
@mcheshkov mcheshkov deleted the extract-wrapper-tests branch October 4, 2024 22:43
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants