fix: Add explicit parameters limit in PostgreSQL and Redshift drivers #8784
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
postgres-redshift-params-limit
branch
from
f4a134c
to
8acaf40
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
postgres-redshift-params-limit
branch
from
8acaf40
to
35ca5a8
Compare
srh
approved these changes
Oct 4, 2024
mcheshkov
force-pushed
the
postgres-redshift-params-limit
branch
from
35ca5a8
to
d66d112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
PostgresDriverusespgmodule as a driver, andpgdoes not check incoming params, and if there's too many it just sends incorrect bind message. It would end up as "expected a lot of params, but 0 was passed" error from server.RedshiftDriverextendsPostgresDriver, but there's another catch: Redshift server misbehaves a little, and breaks on 32768 or more parameters withthere is no parameter $-32768.There's not much we can do about it, but at least we can make error messages clear.