Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: syncronize connections for new translation #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhotadhari
Copy link

Fix error undefined variable fromConnection in /wp-content/plugins/p2p-wpml/synchonizer.php on line 194.

Reproduce the error:

  1. Create two custom post types and register a p2p connection.
  2. Add new post (post_type_a) and set some connections to posts (post_type_b).
  3. Add a translation to that post (post_type_a).
  • The error happens here.
  • The translated post (post_type_a) doesn't have any translated posts (post_type_b) connected.

After the fix the synchronization works. Tested in gutenberg.
WordPress 5.2.2
wpml 4.2.7.1
p2p--wpml 1.2.5

Fix error `undefined variable fromConnection in /wp-content/plugins/p2p-wpml/synchonizer.php on line 194`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant