implement and spec GCP stored path substitutions

app/models/storage_provider.rb

@@ -7,7 +7,7 @@ class StorageProvider < ApplicationRecord
 
   def raise_unimplemented_storage_type_error!
     raise NotImplementedError,
-          "StorageProvider storage_type #{storage_provider.storage_type} "\
+          "StorageProvider storage_type #{self.storage_type} "\
           'is not implemented yet.'
   end
 
@@ -59,25 +59,32 @@ def perform_transfer(pending_transfer, stored_object_key, metadata:, tags: {})
   end
 
   def local_path_to_stored_path(local_path)
-    if self.storage_type == 'aws'
-      local_path_key_map = AWS_CONFIG[:local_path_key_map]
-      matching_local_path_prefix = local_path_key_map.keys.find do |local_file_prefix|
-        local_path.start_with?(local_file_prefix.to_s)
-      end
-
-      if matching_local_path_prefix.nil?
-        raise "Could not find #{self.storage_type} storage provider "\
-              "mapping for #{local_path}"
-      end
+    matching_local_path_prefix = local_path_key_map.keys.find do |local_file_prefix|
+      local_path.start_with?(local_file_prefix.to_s)
+    end
 
-      return local_path.sub(matching_local_path_prefix.to_s, local_path_key_map[matching_local_path_prefix])
+    if matching_local_path_prefix.nil?
+      raise "Could not find #{self.storage_type} storage provider "\
+            "mapping for #{local_path}"
     end
 
-    raise_unimplemented_storage_type_error!
+    local_path.sub(matching_local_path_prefix.to_s, local_path_key_map[matching_local_path_prefix])
   end
 
   private
 
+  def local_path_key_map
+    @local_path_key_map ||=
+      case self.storage_type
+      when 'aws'
+        AWS_CONFIG[:local_path_key_map]
+      when 'gcp'
+        GCP_CONFIG[:local_path_key_map]
+      else
+        raise_unimplemented_storage_type_error!
+      end
+  end
+
   def aws_upload_file_opts(pending_transfer, metadata:, tags:)
     {
       overwrite: false, # This will raise an Atc::Exceptions::ObjectExists error if the object exists

spec/factories/storage_providers.rb

@@ -23,5 +23,16 @@
         )
       end
     end
+
+    trait :cul do
+      initialize_with do
+        storage_type = StorageProvider.storage_types[:cul]
+        container_name = '/digital/working'
+        StorageProvider.find_by(storage_type: storage_type, container_name: container_name) || StorageProvider.create(
+          storage_type: storage_type,
+          container_name: container_name
+        )
+      end
+    end
   end
 end

spec/models/storage_provider_spec.rb

@@ -53,6 +53,15 @@
         )
       end
     end
+
+    describe '#local_path_to_stored_path' do
+      let(:local_path) { '/digital/preservation/a/b/c' }
+      let(:stored_path) { 'a/b/c' }
+
+      it 'substitutes as expected' do
+        expect(storage_provider.local_path_to_stored_path(local_path)).to eql(stored_path)
+      end
+    end
   end
 
   context 'GCP provider type' do
@@ -107,6 +116,27 @@
         )
       end
     end
+
+    describe '#local_path_to_stored_path' do
+      let(:local_path) { '/digital/preservation/a/b/c' }
+      let(:stored_path) { 'a/b/c' }
+
+      it 'substitutes as expected' do
+        expect(storage_provider.local_path_to_stored_path(local_path)).to eql(stored_path)
+      end
+    end
+  end
+
+  context 'CUL provider type' do
+    subject(:storage_provider) { FactoryBot.build(:storage_provider, :cul) }
+
+    describe '#local_path_to_stored_path' do
+      let(:local_path) { '/digital/preservation/a/b/c' }
+
+      it 'substitutes as expected' do
+        expect { storage_provider.local_path_to_stored_path(local_path) }.to raise_error(NotImplementedError)
+      end
+    end
   end
 
   describe 'validations' do