Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atc::Gcp::StorageUploader retries an upload when a Google::Cloud::UnavailableError is encountered #62

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

elohanlon
Copy link
Member

No description provided.

@elohanlon elohanlon force-pushed the Google-Cloud-UnavailableError-retry branch 4 times, most recently from 68aba62 to 3b5de2e Compare December 20, 2024 18:06
@fcd1 fcd1 self-requested a review December 20, 2024 18:22
Copy link
Contributor

@fcd1 fcd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved. The one comment I left is more of a question, not a requested change.

lib/atc/gcp/storage_uploader.rb Outdated Show resolved Hide resolved
@JackBlackLight
Copy link

Interesting library. Thanks for pointing this out @elohanlon

@elohanlon elohanlon force-pushed the Google-Cloud-UnavailableError-retry branch from 3b5de2e to 106ab84 Compare December 20, 2024 20:49
@elohanlon
Copy link
Member Author

@fcd1 @JackBlackLight Thank you for taking a look!

@elohanlon elohanlon merged commit 51c4f79 into main Dec 20, 2024
1 check passed
@elohanlon elohanlon deleted the Google-Cloud-UnavailableError-retry branch December 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants