DLC-1152 public assets #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orized - likewise publicy accessible content - DLC-1152
…ontext (DLC-1127)
JackBlackLight
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@barmintor, everything looks good. I left a comment where I think I may have spotted a debug statement.
| end | ||
| end | ||
| end | ||
|
|
||
| def show | ||
| render json: child(params['id']), :content_type => 'application/json' # Yes, content_type seems redundant here, but the header wasn't getting sent. | ||
| puts child(params['id']).inspect |
There was a problem hiding this comment.
was this left in during debugging?
There was a problem hiding this comment.
Yes! Fixed (and thanks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several commits here to address minor bugs in v1.14.0
Ideally we will deploy these in a patch next Tuesday
The changes are deployed to staging