Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twas output data update and twas pipeline workflow update #1056

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

Chunmingl
Copy link
Contributor

Changes implemented:

  • we add susie_weights_intermediate objects to the twas weights results, to be used for twas and ctwas pipeline
  • we do not select top variants at twas pipeline and instead we export top model weights as export_twas_weights_db that includes all variants.
  • we use raw r2 to select the best model, instead of previous adjusted rsq, this also applies to the final twas table result output that we output rsq instead of adjusted rsq.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Chunmingl Chunmingl force-pushed the main branch 2 times, most recently from c57999e to 5d0612f Compare September 13, 2024 06:26
@gaow gaow merged commit a586c8e into cumc:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants